Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eslint config #1779

Merged
merged 3 commits into from
Aug 12, 2024
Merged

fix: eslint config #1779

merged 3 commits into from
Aug 12, 2024

Conversation

ripecosta
Copy link
Contributor

Description

ESLint will now run on commit alongside Prettier and will no longer ignore TS files.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file are all formatting related exception for the overrides at the bottom.

@adrai adrai merged commit ed956ac into i18next:master Aug 12, 2024
6 checks passed
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this piece of config into the root .eslintrc.json so it's easier to upgrade to ESLint v9's flat config in the future.

@coveralls
Copy link

Coverage Status

coverage: 97.17% (-0.004%) from 97.174%
when pulling 7098756 on ripecosta:rc/eslint
into 4d9bc0b on i18next:master.

@ripecosta ripecosta deleted the rc/eslint branch August 12, 2024 19:33
@ripecosta ripecosta mentioned this pull request Aug 12, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants